Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coinchooser: make output value rounding configurable #3878

Merged
merged 1 commit into from
Feb 9, 2018

Conversation

SomberNight
Copy link
Member

@SomberNight SomberNight commented Feb 8, 2018

  • introduce a config variable coin_chooser_output_rounding that enables/disables output value rounding by the coinchooser
  • by default it is disabled
  • expose control of config variable to qt gui
  • also; changed how the rounding works if there is only one change output
    • the rounding logic seems to have been written with multiple change outputs in mind; where it makes sense to allow a change output to have more-or-less precision than other outputs
    • with only one change output, the ideal outcome should be to have a change output that doesn't have the most precision; with this change we aim for as much precision as the otherwise most precise output

closes #3255

@SomberNight
Copy link
Member Author

updated.

@ecdsa ecdsa merged commit cccf380 into spesmilo:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fee selection not satoshi accurate. Fee is round up
2 participants